Fix ros2 component topics#46
Merged
danthony06 merged 2 commits intoswri-robotics:dashing-develfrom Mar 28, 2022
Merged
Conversation
Member
|
Let me see if I can take a look at this today and think through the change. |
Author
|
Thanks for looking into this. It's a great help.
I'm keen to support if I can. Let me know if there's anything I can do.
Best wishes
Dave
…On Tue, 26 Oct 2021 at 16:29, David Anthony ***@***.***> wrote:
Let me see if I can take a look at this today and think through the change.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#46 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGHWOVXVKC5LHRJQAOZUG3LUI3CMDANCNFSM5GYDFXHA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
daveshed
force-pushed
the
ros2-component-fix
branch
from
8b9b4cf to
d3a815a
Compare
Emit gps/navsat fix messages on timer tick.
daveshed
force-pushed
the
ros2-component-fix
branch
from
d3a815a to
1ddc750
Compare
SivertHavso
suggested changes
Feb 5, 2022
SivertHavso
left a comment
SivertHavso
left a comment
There was a problem hiding this comment.
Added a few suggestions.
Hope this pull request gets merged soon.
Co-authored-by: Sivert Havso <sivert@havso.net>
Member
|
Sorry for the long delay in getting this merged, but it's in now. I'm going to work on releasing it soon after we get another couple of issues merged in. |
1 similar comment
Member
|
Sorry for the long delay in getting this merged, but it's in now. I'm going to work on releasing it soon after we get another couple of issues merged in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emit gps/navsat fix messages on timer tick. Without this commit, no topics are visible when the component is started like this...
ros2 component standalone gpsd_client gpsd_client::GPSDClientComponentThis commit fixes this issue by creating a timer that calls the step function to update gps state and publish data.