[ASTDumper] Print the USR for a protocol conformance's declaring context. #85845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ext.
It's useful to know where a conformance is coming from when doing semantic
analysis. The main motivating use case is this: imagine a module that
declares a type:
```swift
// SomeTypeModule
struct SomeType {}
```
Then a second module that adds a conformance:
```swift
// SomeTypeConformanceModule
extension SomeType: @retroactive Codable {
// implementation of requirements
}
```
Then a third module that uses that conformance:
```swift
import SomeTypeModule
import SomeTypeConformanceModule
func f() {
_ = try? JSONEncoder().encode(SomeType())
}
```
There's currently nothing in the printed AST that indicates that the import
of `SomeTypeConformanceModule` is required. Printing the declaring context
for conformances lets us get that signal from the substitution map at the
call site in `f()`.
Also removed a place where we redundantly output `retroactive`.
allevato
requested review from
artemcm,
hborla,
slavapestov,
tshortli and
xedin
as code owners
Member
Author
|
@swift-ci please smoke test |
Member
Author
|
@slavapestov Does this seem like a reasonable way to represent this? (Hoping to get this into 6.3 🤞🏻 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's useful to know where a conformance is coming from when doing semantic analysis. The main motivating use case is this: imagine a module that declares a type:
Then a second module that adds a conformance:
Then a third module that uses that conformance:
There's currently nothing in the printed AST that indicates that the import of
SomeTypeConformanceModuleis required. Printing the declaring context for conformances lets us get that signal from the substitution map at the call site inf().Also removed a place where we redundantly output
retroactive.