Skip to content

generator: Use Swift 6.2.1 by default #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MaxDesiatov merged 3 commits into from
Nov 10, 2025
Merged

generator: Use Swift 6.2.1 by default #246

MaxDesiatov merged 3 commits into from
Nov 10, 2025

Conversation

@euanh
Copy link
Contributor

@euanh euanh commented Sep 25, 2025

No description provided.

@euanh euanh requested a review from MaxDesiatov as a code owner September 25, 2025 13:27
@euanh
Copy link
Contributor Author

euanh commented Sep 25, 2025

@swift-ci test

@xtremekforever
Copy link
Contributor

xtremekforever commented Sep 25, 2025

Easy enough, however do you want to add 6.2 to the E2E matrix?

@MaxDesiatov
Copy link
Contributor

MaxDesiatov commented Sep 26, 2025

I concur, this deserves to include an addition to Tests/SwiftSDKGeneratorTests/EndToEndTests.swift

@Joannis
Copy link
Member

Joannis commented Nov 5, 2025

@euanh did you see the above comments?

@euanh
Copy link
Contributor Author

euanh commented Nov 5, 2025

@swift-ci test

@euanh
Copy link
Contributor Author

euanh commented Nov 5, 2025

@swift-ci test

@euanh
Copy link
Contributor Author

euanh commented Nov 6, 2025 •
edited
Loading

Thanks @Joannis

@MaxDesiatov I've updated the tests. There's a lot of duplication now and we should try to reduce it.

  • In Bump swift-tools-version to 6.0 #237 you mentioned that we're no longer directly testing 5.9 and 5.10: shall we drop the end to end tests for those versions as well?
  • If we merge Bump swift-tools-version to 6.0 #237, we should translate the end to end tests to swift-testing parameterised tests.
    I'd prefer to merge this PR as-is and make those changes in their own PRs.

MaxDesiatov
MaxDesiatov reviewed Nov 10, 2025
View reviewed changes
Sources/GeneratorCLI/GeneratorCLI.swift Outdated

@Option(help: "Version of Swift to supply in the bundle.")
var swiftVersion = "6.1.2-RELEASE"
var swiftVersion = "6.2-RELEASE"
Copy link
Contributor

@MaxDesiatov MaxDesiatov Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks! Just one suggestion here, maybe we should update it to use 6.2.1 now that's out?

@euanh
Copy link
Contributor Author

euanh commented Nov 10, 2025

@swift-ci test

@euanh euanh changed the title generator: Use Swift 6.2 by default generator: Use Swift 6.2.1 by default Nov 10, 2025
@MaxDesiatov MaxDesiatov merged commit 01e610b into swiftlang:main Nov 10, 2025
41 checks passed
@euanh euanh deleted the swift-6.2 branch November 11, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@euanh @xtremekforever @MaxDesiatov @Joannis