Skip to content

Verbosity fix #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johnbute wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Verbosity fix #943

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32b6d36
fixed verbosity causing rebuild issue
Nov 26, 2025
53d3d12
changed for added clarity
Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions Sources/SWBCore/BuildParameters.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ public struct BuildParameters: Hashable, SerializableCodable, Sendable {
try container.encodeIfPresent(activeRunDestination, forKey: .activeRunDestination)
try container.encodeIfPresent(activeArchitecture, forKey: .activeArchitecture)
try container.encodeIfPresent(arena, forKey: .arena)
try container.encode(overrides, forKey: .overrides)
try container.encode(filterOverrides(overrides), forKey: .overrides)
try container.encode(commandLineOverrides, forKey: .commandLineOverrides)
try container.encodeIfPresent(commandLineConfigOverridesPath, forKey: .commandLineConfigOverridesPath)
try container.encode(commandLineConfigOverrides, forKey: .commandLineConfigOverrides)
Expand Down Expand Up @@ -228,7 +228,7 @@ public struct BuildParameters: Hashable, SerializableCodable, Sendable {
hasher.combine(activeRunDestination)
hasher.combine(activeArchitecture)
hasher.combine(arena)
hasher.combine(overrides)
hasher.combine(filterOverrides(overrides))
hasher.combine(commandLineOverrides)
hasher.combine(commandLineConfigOverridesPath)
hasher.combine(commandLineConfigOverrides)
Expand All @@ -237,6 +237,15 @@ public struct BuildParameters: Hashable, SerializableCodable, Sendable {
hasher.combine(toolchainOverride)
return hasher.finalize()
}

Copy link
Collaborator

@owenv owenv Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of removing the settings override from the hash here, I think we should add the verbose flag to the output agnostic flags list for clang, swift, and ld, which is a narrower and safer change and ensures if -v.

commandLineForSignature() in SwiftCompilerSpec is an example of how this works today for other flags

private func filterOverrides(_ overrides: [String: String]) -> [String: String] {
overrides.mapValues { value in
// Remove -v flag from the value to avoid rebuild
value.split(separator: " ")
.filter { $0 != "-v" }
.joined(separator: " ")
}
}
}

extension BuildParameters {
Expand Down