[lldb] Add alternative SBThread::GetStopDescription (#165379) #11856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the function signature for `GetStopDescription` is `lldb::SBThread::GetStopDescription(char *dst_or_null, size_t len)`. To get a description you need to call the function first time to get the buffer size. a second time to get the description. This is little worse from the python size as the signature is `lldb.SBThread.GetStopDescription(int: len) -> list[str]` the user has to pass the max size as possible with no way of checking if it is enough. This patch adds a new api `lldb.SBThread.GetStopDescription(desc: lldb.SBStream()) -> bool` `bool lldb::SBThread::GetStopDescription(lldb::SBStream &description)` which handles this case. Adds new Test case for lua. (cherry picked from commit c46bfed)
Author
|
@swift-ci test |
adrian-prantl
approved these changes
Nov 19, 2025
Author
|
https://ci-external.swift.org/job/apple-llvm-project-pull-request-windows/3290/ It looks like the CI is not configured correctly, Is it using some other way to create the swig bindings ? it then later on says it found python and swig but does not display the swig version found. |
Author
|
@swift-ci test macOS |
Author
|
@swift-ci test macOS windows |
1 similar comment
Author
|
@swift-ci test macOS windows |
Author
|
@swift-ci test windows platform |
Author
|
@swift-ci test macos platform |
|
@swift-ci test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the function signature for
GetStopDescriptionislldb::SBThread::GetStopDescription(char *dst_or_null, size_t len). To get a description you need to call the function first time to get the buffer size. a second time to get the description.This is little worse from the python size as the signature is
lldb.SBThread.GetStopDescription(int: len) -> list[str]the user has to pass the max size as possible with no way of checking if it is enough.This patch adds a new api
lldb.SBThread.GetStopDescription(desc: lldb.SBStream()) -> boolbool lldb::SBThread::GetStopDescription(lldb::SBStream &description)which handles this case.Adds new Test case for lua.
(cherry picked from commit c46bfed)