Flexible item size - request for feedback#276
Open
Blackbaud-StewartStephens wants to merge 22 commits intoswiety85:masterfrom
Open
Flexible item size - request for feedback#276Blackbaud-StewartStephens wants to merge 22 commits intoswiety85:masterfrom
Blackbaud-StewartStephens wants to merge 22 commits intoswiety85:masterfrom
Conversation
Owner
|
Hi,
I already started providing a similar solutions (#78) but had not enough time to finish it. In the end, my idea to solve this problem is to have a directive: #138. This approach seems to not interfere so much in the core of gridster and I think in the end will be less problematic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I'm working on a modification of this project which will enable some gridster items to have a flexible height, based on the size of their contents. I know that flexible item sizes is on your roadmap, so I was hoping you could look over my approach and provide some feedback.
Currently, cell height is computed by the cell width multiplied by a specified ratio, and every row is the same height. With my change, a row's height is computed in one of two different ways:
Items which are not variable height expand to fit their cells as expected.
I did a quick update to the demo, but I wound up breaking scrolling somehow. Also, I did not implement variable width, and I did not test with horizontal direction, since neither of those are requirements for my current project.
Thank you for your time.