chore(deps): update dependency fixpack to v4#128
Open
renovate[bot] wants to merge 1 commit into
Open
Conversation
Member
|
@beverts312 - i don't imagine getting around to this in the near future, but any thoughts/concerns with the update? The one thing that jumps out to me is the change of the default behavior to maintain existing indentation levels, and line feeds, and instead requiring configuration to change those. i've become rather partial to two space indents for json files myself, but that being said, i've also become rather partial to code formatters like prettier too. if we were to introduce something like prettier, both for the source TS files, json, and the others, then we could leave the fixpack defaults as-is and let it do the reordering and such, and then just rely on prettier for indentation, line endings, etc. |
e278f2b to
a8d1f48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^3.0.6->^4.0.0Release Notes
henrikjoreteg/fixpack
v4.0.0Compare Source
Configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by WhiteSource Renovate. View repository job log here.