Feat: Add permExactMatchTrigger Lua function#11
Open
avocado-lynx wants to merge 2 commits intoswe-productivity:developmentfrom
Open
Feat: Add permExactMatchTrigger Lua function#11avocado-lynx wants to merge 2 commits intoswe-productivity:developmentfrom
avocado-lynx wants to merge 2 commits intoswe-productivity:developmentfrom
Conversation
vadi2
reviewed
Mar 20, 2026
Collaborator
vadi2
left a comment
vadi2
left a comment
There was a problem hiding this comment.
Looks good and tests out well, thank you! Just one comment.
| { | ||
| const QString name = getVerifiedString(L, __func__, 1, "trigger name"); | ||
| const QString parent = getVerifiedString(L, __func__, 2, "trigger parent"); | ||
| const QString exactMatchPattern = getVerifiedString(L, __func__, 3, "exact match pattern"); |
Collaborator
There was a problem hiding this comment.
All other perm* functions allow a list of patterns, since a single trigger accepts multiple patterns - see https://wiki.mudlet.org/w/Manual:Lua_Functions#permRegexTrigger as an example. Allowing the same here would help this function stay consistent.
Author
|
Thanks! I've addressed that issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2
This PR adds a new Lua function called
permExactMatchTriggerwhich creates a permanent trigger with a single exact match pattern.