Skip to content

Conversation

@marqh
Copy link

@marqh marqh commented Jan 30, 2017

@katyhuff @gvwilson

I have been through this module, erviewing and considering; I like the content. I would like to introduce the core library module unittest alongside the testing options presented.

I find unittest really useful and lots of new and learning developers are likely to come across it if they work with other people's code.

I have also moved the 'edge cases' page to the end, as it seemed something of a sideline to me (and saved me from too much renumbering).

These are ideas, I'm really keen to discuss them and adapt them if they are interesting for you.

I have not built the content, so the html may be out of sync or missing

all the best
mark

@katyhuff
Copy link

Hi @marqh -- This is not the main fork of this repository. I'm happy to merge new changes in this fork to the actual main fork (katyhuff/python-testing), but it would be much simpler if you re-issue this PR to the main fork (https://github.com/katyhuff/python-testing). Would you mind if we close this PR and conduct the review over in the main one?

@marqh
Copy link
Author

marqh commented Feb 1, 2017

Would you mind if we close this PR and conduct the review over in the main one?

I have created
carpentries-incubator#11

if we're happy to move discussions there, we can close this one

@katyhuff
Copy link

katyhuff commented Feb 1, 2017

Thanks! Much appreciated!

@katyhuff katyhuff closed this Feb 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants