Skip to content

fix: improve error handling for invalid API responses #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brandonhawi wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −1
Open

fix: improve error handling for invalid API responses #605

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/nba_api/library/http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,21 @@ def get_response(self):
return self._response

def get_dict(self):
return json.loads(self._response)
try:
return json.loads(self._response)
except json.JSONDecodeError as e:
if not self._response or self._response.isspace():
raise ValueError(
f"NBA API returned an empty response. "
f"This can happen for various reasons including no data available for the requested parameters. "
f"URL: {self._url}"
) from e
else:
raise ValueError(
f"NBA API returned an invalid JSON response: {str(e)}. "
f"Response content (first 200 chars): {self._response[:200]}... "
f"URL: {self._url}"
) from e

def get_json(self):
return json.dumps(self.get_dict())
Expand Down