Skip to content

feat: add handler#28

Open
rmontagnin wants to merge 1 commit intoswaggo:masterfrom
rmontagnin:master
Open

feat: add handler#28
rmontagnin wants to merge 1 commit intoswaggo:masterfrom
rmontagnin:master

Conversation

@rmontagnin
Copy link
Copy Markdown

Description

This PR adds back the file handler that has been deleted when migrating to support Go embed.

@titouanj
Copy link
Copy Markdown

I see that @easonlin404 is a member of swaggo and a maintainer of this repo. I'm pinging him to see if he can review this PR and maybe the related one in gin-swagger

@ubogdan
Copy link
Copy Markdown
Contributor

ubogdan commented Jun 19, 2025

@titouanj is this related to an issue ?

@titouanj
Copy link
Copy Markdown

titouanj commented Jun 19, 2025

@titouanj is this related to an issue ?

I guess this one is the closest to the actual problem: swaggo/gin-swagger#315

@rmontagnin
Copy link
Copy Markdown
Author

@ubogdan This PR is needed in order to make it possible to properly support OpenAPI Spec v3 by bumping swag to v2. The handler you see in this PR is needed in order to make sure that the generated file can be served properly using the /swag/doc.json REST endpoint

@Utkarsh-dev14
Copy link
Copy Markdown

@ubogdan @easonlin404 Are we merging this PR?? So that we can migrate to v2

@hunshcn
Copy link
Copy Markdown

hunshcn commented Sep 17, 2025

This helps drive the migration to v2.

@ubogdan

@ubogdan
Copy link
Copy Markdown
Contributor

ubogdan commented Sep 17, 2025

@RiccardoM I don't understand why you are going back to WebDAV when we have native embed.FS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants