fix(request-snippets): escape pipe character in cURL CMD snippets#10770
Open
ceykiii wants to merge 1 commit intoswagger-api:masterfrom
Open
fix(request-snippets): escape pipe character in cURL CMD snippets#10770ceykiii wants to merge 1 commit intoswagger-api:masterfrom
ceykiii wants to merge 1 commit intoswagger-api:masterfrom
Conversation
…pets The pipe character `|` was not escaped in the CMD curl snippet generator, causing CMD to interpret it as a command pipe operator when the request body contained `|` characters. Fixed by adding `.replace(/\|/g, "^|")` to the escapeCMD function, which escapes the pipe with the CMD escape character `^`. Fixes swagger-api#10540
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Escape the vertical bar
|character in cURL CMD request snippets to prevent CMD from interpreting it as a pipe operator.Problem
When a request body contains the
|character, the generated CMD curl snippet does not escape it. CMD interprets|as a pipe operator, causing the command to fail with an error.Fix
Added
.replace(/\|/g, "^|")to theescapeCMDfunction insrc/core/plugins/request-snippets/fn.js. The caret^is the standard CMD escape character.Fixes #10540