fix: add so that the Java Deprecated annotation is considered a processable annotation type#5099
Open
Mattias-Sehlstedt wants to merge 2 commits intoswagger-api:masterfrom
Conversation
…e annotation type
Mattias-Sehlstedt
force-pushed
the
consider-deprecated-for-annotated-type
branch
from
b136c63 to
0124121
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Thank you for contributing to swagger-core!
Please fill out the following information to help us review your PR efficiently.
Description
This PR re-adds so that the
@DeprecatedJava annotation is considered a valid "processable" annotation within the project. This change made it so that deprecated was dropped.The background for why it can be dropped is because this project itself does not currently handle
@Deprecatedon properties, but I would agree with #4840 and claim that this project is a suitable place to handle it within. The main issue with the change is that there exists projects that want to handle this themselves, for example springdoc as highlighted here. So to please everyone I would argue that it would be beneficial to reintroduce it.I was unable to find an annotation that had
TYPEas target given the project's language level. Thus why the "ignores JDK annotation"-test is not kept.Fixes: #5043 (and springdoc/springdoc-openapi#3250)
Type of Change
Checklist
Screenshots / Additional Context