Add javax Positive/Negative bean validation constraint support#5052
Closed
Neo1228 wants to merge 1 commit intoswagger-api:masterfrom
Closed
Add javax Positive/Negative bean validation constraint support#5052Neo1228 wants to merge 1 commit intoswagger-api:masterfrom
Neo1228 wants to merge 1 commit intoswagger-api:masterfrom
Conversation
- map Positive/Negative/PositiveOrZero/NegativeOrZero to schema limits - wire constraints in grouped and no-group bean validation flows - add regression tests for non-loosening behavior with stronger Min/Max
Author
|
Closing as duplicate of #5044 to avoid overlap. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
javax.validation.constraints.Positive,Negative,PositiveOrZero, andNegativeOrZeroin bean validation schema resolutionminimum/maximumandexclusiveMinimum/exclusiveMaximum)ModelResolverDetails
@Positive=>minimum: 0,exclusiveMinimum: true@Negative=>maximum: 0,exclusiveMaximum: true@PositiveOrZero=>minimum: 0,exclusiveMinimum: false@NegativeOrZero=>maximum: 0,exclusiveMaximum: falseWhen existing bounds are already stricter (for example
@Min(5)with@Positive), the stricter bound is preserved.Tests
BeanValidationTest@Min/@MaxValidationAnnotationsUtilsTestCommands run:
mvn -pl modules/swagger-core "-Dtest=io.swagger.v3.core.resolving.BeanValidationTest,io.swagger.v3.core.util.ValidationAnnotationsUtilsTest" testmvn test -pl modules/swagger-core