[perf]: only create objects for completion items for svelte syntax once#2900
Merged
jasonlyu123 merged 4 commits intosveltejs:masterfrom Dec 20, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 73cb6a9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
I don't see any reason why we would need to do this dynamically, so this change is moving in a sensible direction. Not much gained from the change though. Plus it feels odd to have these features just inlined here and not imported from some centralized language feature metadata location or something, but that's a larger and separate discussion. |
aewing
approved these changes
Dec 19, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-creating these objects every time
getCompletionsWithRegardToTriggerCharacteris called is unnecessary. Only creating them once should free up a small bit of memory.