[codex] Add COMSOL live inspect targets#26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
comsol.model.describe,comsol.model.describe_text, andcomsol.node.properties:<target>throughComsolDriver.query().describe()/format_text()helpers and mark the describe outputpartial=truebecause the helper currently covers physics interfaces and features.component.comp1.physics.ht.feature.temp1, and tag-only lookups, such astemp1.Refs svd-ai-lab/sim-proj#141.
Why
The bundled COMSOL skill already told agents to use these inspect targets, but the driver only exposed
session.health,comsol.model.identity, andui.modes. Agents following the skill would hitunknown inspect targetand fall back to manual read-only snippets. This PR closes that driver/skill contract gap.Validation
uv run pytest tests/test_comsol_driver.py -q --basetemp .pytest_basetemp/comsol_query_targets-> 42 passeduv run pytest tests -q --basetemp .pytest_basetemp/all-> 110 passed, 1 skippeduv run sim --json check comsol-> detected COMSOL 6.4.0.293 atC:\Program Files\COMSOL\COMSOL64\Multiphysics, profilecomsol_64_mph_1uv run sim --json connect --solver comsol --ui-mode no_guiuv run sim --json exec --file src\sim_plugin_comsol\_skills\comsol\base\workflows\block_with_hole\00_create_geometry.py --label live-query-geometryuv run sim --json exec --file src\sim_plugin_comsol\_skills\comsol\base\workflows\block_with_hole\02_setup_physics.py --label live-query-physicsuv run sim --json inspect comsol.model.describe-> returnedok=true,what=physics,htfeatures includingtemp1uv run sim --json inspect comsol.model.describe_text-> returned text includingTemperatureBoundaryandT0=373[K]uv run sim --json inspect 'comsol.node.properties:component.comp1.physics.ht.feature.temp1'-> returnedT0=373[K]uv run sim --json inspect 'comsol.node.properties:temp1'-> returnedT0=373[K]ComsolDriver().launch(ui_mode="gui", visual_mode="shared-desktop", desktop_timeout=90)->effective_ui_mode=shared-desktop,model_builder_live=true,live_model_binding.ok=true,comsol.model.identity.ok=true,comsol.model.describe.ok=truegit diff --check-> clean apart from Windows CRLF conversion warnings