Flatten a series of simple schedules#82
Conversation
gonuke
left a comment
gonuke
left a comment
There was a problem hiding this comment.
Looking for some consistency in return quantities across the set of functions are are developing...
| all_sched_t_irr += sched_t_irr | ||
| all_sched_abt += sched_active_burn_time | ||
| tot_ff = all_sched_abt / all_sched_t_irr | ||
| return all_sched_t_irr, tot_ff |
There was a problem hiding this comment.
Noting that you changed which quantities are being returned by the previous function... I think it makes sense to have all these function return a consistent pair of values, any two of:
- total irradiation time
- total burn time
- flux factor
Since the third can always be inferred from any other two, it makes sense to allow users to have an assumption about which two it will be by being consistent across the various functions.
There was a problem hiding this comment.
Changed flatten_simple_sched() to have it return irradiation time and flux factor as before.
gonuke
left a comment
gonuke
left a comment
There was a problem hiding this comment.
I think this looks OK, but we should start thinking about data structures that may be more robust than parallel iterables that we hope don't get misaligned.
2 participants
Builds upon #78 to extend the flattening approximation to multiple simple schedules.
fixes #23