Added Video Section #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinsheen
requested review from
a user,
KMcWeeney22,
hlkessner,
lariosw and
lukevpoel
Collaborator
|
I would add more alt text to the video section, just to make it more accessible to screen readers. |
KMcWeeney22
approved these changes
Feb 19, 2017
Collaborator
KMcWeeney22
left a comment
KMcWeeney22
left a comment
There was a problem hiding this comment.
Besides adding the alt text to the video, everything looks good and wont cause any errors to the master and can be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In regards to Issue #2, for accessible video captions, I added a video section with a small embedded YouTube video of Maya Angelou. I thought it would be nice to have a part of the site dedicated to live performances of poetry/readings, I then added the playlist link that has sub-titles ready and available. Should the video embed size be bigger? The size is pretty small at the moment. And should we had more alt text to the video section?