Added Alternative Text to Index File #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinsheen
requested review from
a user,
KMcWeeney22,
hlkessner,
lariosw and
lukevpoel
ghost
reviewed
Feb 12, 2017
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Ah yea, good catch! The text should be PDG Poetry.
lariosw
approved these changes
Feb 12, 2017
Collaborator
lariosw
left a comment
lariosw
left a comment
There was a problem hiding this comment.
Seems like you identified the alt tags and I think these changes should be merged.
KMcWeeney22
approved these changes
Feb 19, 2017
Collaborator
KMcWeeney22
left a comment
KMcWeeney22
left a comment
There was a problem hiding this comment.
Everything looks good with the alt text and can be merged with the master branch.
lukevpoel
approved these changes
Feb 20, 2017
Collaborator
lukevpoel
left a comment
lukevpoel
left a comment
There was a problem hiding this comment.
Overall looks like a good commit. Small changes. Nothing that broke any other parts of the html.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In regards to Issue #1, this branch has been updated with alternative text for potential screen readers and hopefully gives more page descriptions. And buttons got the alt text addition as well. Although I did realize just now that the title should be PDG Poetry? Not Tranquil Prestige in the head as well as navigation section. Any other alt text uses we should try?