Conversation
| <div class="container"> | ||
| <h1>Maya Angelou</h1> | ||
| <figure> | ||
| <img src="/media/maya-image.jpg" alt="" width="320" height="213"> |
There was a problem hiding this comment.
Luke, I like your layout for the bio-page and the image you chose!
Might seem obvious but I'd rather over-communicate than miss it all together! When we merge we'll need to make sure that the media directory is included in the master so the audio and image files work correctly.
Since the featured-poem and content branches don't have a media folder yet, we should watch for this when we merge these branches to make sure we don't accidentally overwrite the media folder in the process.
There was a problem hiding this comment.
Good catch, Kira. Definitely an important thing to keep our eyes open for!
| </nav> | ||
|
|
||
| <!-- Main jumbotron for a primary marketing message or call to action --> | ||
| <div class="jumbotron"> |
There was a problem hiding this comment.
Nice work! 👍 I like how you used the Jumbotron to style the bio-section prominently. Was it intentional to have the jumbotron outside of a container? If we switch the <div class="jumbotron"> and <div class="container"> tags, then clean up the div's at the end of the container, it fixes the footer alignment issue on this page.
There was a problem hiding this comment.
Indeed, although you branched this bio.html page in the content branch and continued to develop from this code there, so we would probably just ignore this branch completely, right?
|
|
||
| <p><a class="btn btn-primary btn-lg" href="#" role="button">Learn more »</a></p> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
Delete the extra <div> tag. See comment on line 64 above.
lukeware
left a comment
lukeware
left a comment
There was a problem hiding this comment.
This branch should be closed without being merged. All work here was copied to the bio.html page of the content branch. Code review the bio should be done there.
| </nav> | ||
|
|
||
| <!-- Main jumbotron for a primary marketing message or call to action --> | ||
| <div class="jumbotron"> |
There was a problem hiding this comment.
Indeed, although you branched this bio.html page in the content branch and continued to develop from this code there, so we would probably just ignore this branch completely, right?
3 participants
Issue: #4
Hey all, it looks like the latest work by Kira in the bio page happened in the content branch which likely makes this pull request avoid. Doing it anyway, because, you know, homework! Plus clicking the green "create pull request" makes me feel powerful. Would should have happened here is I made the bio page and then created a new pull request that Kira could then work on. Since thats not how the assignments were design though, we didn't end up doing that until this week. That's not a problem and Shawn/Jackie know thats often what happens here. Go Sounders.