Conversation
| but longed for still” | ||
| </p> | ||
| <a class="btn btn-primary" href="#">Read More <span class="glyphicon glyphicon-chevron-right"></span></a> | ||
| <a class="btn btn-primary" href="/media/Maya-Angelou-Caged-Bird.mp3">Listen <span class="glyphicon glyphicon-music"></span></a> |
There was a problem hiding this comment.
Awesome work with the audio tracks! It's great that you included tracks of the poems being read live, in my opinion that provides a much better experience for the user than automated or dull narration.
If we had more time to work on this it would be awesome to hone in on the listening option a bit more. Maybe we could allow users to listen to the audio while reading along with the full poem in the modal? It would also be helpful for the user to have an option to close the audio view without having to rely on the back button with their browser.
kiranw06
left a comment
kiranw06
left a comment
There was a problem hiding this comment.
Everything is looking good here! I like how you built out the audio feature because it it improves accessibility and the overall user experience for everyone. 👍
Like I've mentioned in reviewing our other branches we'll just need to watch to make sure we don't accidentally overwrite changes in the merging process. In this case we'll have to make sure we merge the audio features to the most up to date version of the archive page.
meganmotis
left a comment
meganmotis
left a comment
There was a problem hiding this comment.
Excellent job with the accessible media, Luke!
| You may stand upon me, <br> | ||
| But do not hide your face.”</p> | ||
| <a class="btn btn-primary" href="#">Read More <span class="glyphicon glyphicon-chevron-right"></span></a> | ||
| <a class="btn btn-primary" href="/media/Maya-Angelou-On-the-Pulse-of-the-Morning.mp3">Listen <span class="glyphicon glyphicon-music"></span></a> |
There was a problem hiding this comment.
Nice work adding in the glyphicon-music. I think little touches like those go a long way towards the usability of the site.
| <div class="container"> | ||
| <h1>Maya Angelou</h1> | ||
| <figure> | ||
| <img src="/media/maya-image.jpg" alt="" width="320" height="213"> |
There was a problem hiding this comment.
I like this image of Maya, though I'm wondering if you considered using the class 'img-responsive' instead of setting a fixed width and height?
| Your hands”<br> | ||
| </p> | ||
| <a class="btn btn-primary" href="#">Read More <span class="glyphicon glyphicon-chevron-right"></span></a> | ||
| <a class="btn btn-primary" href="/media/Maya-Angelou-Human-Family.mp3">Listen <span class="glyphicon glyphicon-music"></span></a> |
There was a problem hiding this comment.
Luke, really nice job with the accessible media and finding all of these great .mp3 versions of the poems.
3 participants
Issue: #1
This branch added listen buttons to each poem in the archive. The buttons link to corresponding media files in the /media folder for each poem. Once there is a pull request for the poetry archive page I will be able to see how the content has changed and then we will be able to update the media links accordingly.