Open
Conversation
kiranw06
reviewed
Nov 13, 2016
| <div class="col-md-6"> | ||
| <h2>Discover the Poet</h2> | ||
| <p>Find out more about Maya Angelou.</p> | ||
| <p><a class="btn btn-default" href="#" role="button">View Bio »</a></p> |
Collaborator
There was a problem hiding this comment.
Good thinking adding a link to the bio-page in the marketing area! 👍 One quick fix though, this button is missing a URL. Lets add the missing link!
<a class="btn btn-default" href="bio.html" role="button">
kiranw06
approved these changes
Nov 13, 2016
Collaborator
kiranw06
left a comment
kiranw06
left a comment
There was a problem hiding this comment.
Nice work with this branch! I your code definitely fulfills the requirements we set for navigation, poem features, and has a good feel on the homepage overall. I left a few line specific comments with some ideas for minor html fixes that could help refine a few things.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Team, this branch features work addressing Issue #5 (Global Navigation) and Issue #6 (Home page with randomly selected featured poem. So as I added the navigation, I made changes to the bio.html and archive-index.html pages as well as the home.html page so we have a functional navigation across all three pages. The home page also has a featured poem in the jumbotron div and two columns beneath to point users to the bio page and archive. (If we were going further I would say we would need to get script written to randomly display a new poem each day, but for this exercise I think we're probably good as is.)