DanielShaked mp3 player#35
Open
DanielShaked wants to merge 11 commits intosuvelocity:masterfrom
DanielShaked:DanielShaked_mp3Player
Open
DanielShaked mp3 player#35DanielShaked wants to merge 11 commits intosuvelocity:masterfrom DanielShaked:DanielShaked_mp3Player
DanielShaked wants to merge 11 commits intosuvelocity:masterfrom
DanielShaked:DanielShaked_mp3Player
Conversation
I created the function playSong In addition I created 2 helo functions: 1. secToMmSs - format mm:ss 2. songById - find song index by the id.
Create a remove function from the player and playlist
addSong function. also create mmToSec function, and generateid function
create removePlaylist; also add throw new on getIndexPl
create a createPlaylist; also create a checkIdAvilablePl Function
create a playPlaylist Function, also do some visual changes and fixes
create a editPlaylist function. also fixes some bugs. feel goood ;)
create a new Function - playlistDuration.
create searchByQuery Function only.
create searchByDuration. also: 1. Format code 2. fix bugs 3. Improving visibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I really enjoyed writing the code 🙏
I focused mainly on: