Skip to content

Cleaning4 l#94

Open
tinapotter wants to merge 2 commits intosusynt:masterfrom
tinapotter:Cleaning4L
Open

Cleaning4 l#94
tinapotter wants to merge 2 commits intosusynt:masterfrom
tinapotter:Cleaning4L

Conversation

@tinapotter
Copy link
Collaborator

Cleaning up repeated overlap removal code for 4L.
Fix to 4L OR class to add method like the base class.

@mikeflowerdew
Copy link
Collaborator

Amongst other things, this fixes a bug where the OverlapTools::performOverlap was hidden by OverlapTools_4Lep::perform overlap, leading to potentially inconsistent behaviour depending on which kind of pointer is used.
https://isocpp.org/wiki/faq/strange-inheritance#hiding-rule
(Incidentally, the warning mentioned in the link is itself suppressed, I guess because the Makefile.RootCore doesn't specify the pedantic mode. This seems a little dangerous IMO)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants