FreeBSD requires sin_len field to be set.

[vlm]

Otherwise e.g. valgrind complains.

[sustrik]

Is this causing problems?

AFAIU this field is not required to be set, see here:

http://stackoverflow.com/questions/38913326/are-sockaddr-in-and-sockaddr-in6-still-using-sin-len-and-sin6-len

[vlm]

Valgrind complains if it is not set properly. Also, older versions of freebsd wouldn't work, and afair solaris, too.

…

-- Lev

On Mar 24, 2017, at 21:58, sustrik ***@***.***> wrote: Is this causing problems? AFAIU this field is not required to be set, see here: http://stackoverflow.com/questions/38913326/are-sockaddr-in-and-sockaddr-in6-still-using-sin-len-and-sin6-len — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[sustrik]

Fair enough. Thanks for the patch!

[vlm]

Yeah, if you noticed there's a provision for setting the sin_len in the DNS library (the #if defined(SA_LEN) which I've extended), but it wasn't consistently applied.

[vlm]

Also, wahern/dns#21