fix: Isolation level and reservation table #1201
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porcellus
requested changes
Dec 15, 2025
| @@ -0,0 +1,25 @@ | |||
| { | |||
Collaborator
There was a problem hiding this comment.
Why are these being added now?
| con.setRequestMethod(method); | ||
| con.setConnectTimeout(connectionTimeoutMS); | ||
| con.setReadTimeout(readTimeoutMS + 1000); | ||
| con.setReadTimeout(readTimeoutMS * 3); |
Collaborator
There was a problem hiding this comment.
This is a bit confusing. (both the original + 1k and the current *3)
Comment on lines
-226
to
-238
| synchronized (syncObject) { | ||
| t1State.set("read"); | ||
| syncObject.notifyAll(); | ||
| } | ||
| Runnable r1 = () -> { | ||
| try { | ||
| sqlStorage.startTransaction(con -> { | ||
| tryCount1.incrementAndGet(); | ||
|
|
||
| synchronized (syncObject) { | ||
| while (!t2State.get().equals("read")) { | ||
| try { | ||
| syncObject.wait(); | ||
| } catch (InterruptedException e) { | ||
| } | ||
| } | ||
| } |
| tenantIds.addAll(primaryUser.tenantIds); | ||
|
|
||
| checkIfLoginMethodCanBeLinkedOnTenant(con, appIdentifier, authRecipeStorage, tenantIds, recipeUser.loginMethods[0], primaryUser); | ||
| Set<String> emails = new HashSet<>(); |
Collaborator
There was a problem hiding this comment.
we have a for update lock on both the primary and recipe user at this point, right?
| Set<LoginMethod.ThirdParty> thirdParties = new HashSet<>(); | ||
|
|
||
| for (LoginMethod currLoginMethod : primaryUser.loginMethods) { | ||
| checkIfLoginMethodCanBeLinkedOnTenant(con, appIdentifier, authRecipeStorage, tenantIds, currLoginMethod, primaryUser); |
Collaborator
There was a problem hiding this comment.
Can we remove the util function we used to use?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
(A few sentences about this PR)
Related issues
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your
changes work. Bonus points for screenshots and videos!)
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here
highlighting the necessary changes)
Checklist for important updates
coreDriverInterfaceSupported.jsonfile has been updated (if needed)pluginInterfaceSupported.jsonfile has been updated (if needed)build.gradlegetPaidFeatureStatsfunction in FeatureFlag.java filebuild.gradle, please make sure to add themin
implementationDependencies.json.getValidFieldsinio/supertokens/config/CoreConfig.javaif new aliases were added for any coreconfig (similar to the
access_token_signing_key_update_intervalconfig alias).git tag) in the formatvX.Y.Z, and then find thelatest branch (
git branch --all) whoseX.Yis greater than the latest released tag.app_id_to_user_idtable, make sure to delete from this table when deletingthe user as well if
deleteUserIdMappingToois false.Remaining TODOs for this PR