Skip to content

fix: In custom component builder page, we shouldn't show "last event" / "last run" section of nodes#3509

Closed
cursor[bot] wants to merge 1 commit intomainfrom
cursor/builder-node-last-event-8d7f
Closed

fix: In custom component builder page, we shouldn't show "last event" / "last run" section of nodes#3509
cursor[bot] wants to merge 1 commit intomainfrom
cursor/builder-node-last-event-8d7f

Conversation

@cursor
Copy link
Copy Markdown
Contributor

@cursor cursor Bot commented Mar 18, 2026

Summary

In the custom component builder page, there are no events or executions, so the "last event" / "last run" sections on nodes should not be shown.

Changes

  • web_src/src/pages/custom-component/index.tsx: Simplified getBlockType to always return "component" type in the builder. Previously, merge components mapped to the "merge" block type, which used MergeComponent with its own empty state rendering that couldn't be suppressed. By using "component" type for all nodes, they all render through ComponentBase where includeEmptyState: false is explicitly set and eventSections is already undefined (since lastExecutions is always empty in the builder).

  • web_src/src/ui/CustomComponentBuilderPage/storybooks/mockBlueprint.tsx: Removed hardcoded eventSections from storybook mock data so the storybook accurately represents how builder nodes appear without event/execution data.

How it works

The builder's createBlockData function already correctly:

  1. Passes lastExecutions: [] to mappers, which return eventSections: undefined
  2. Overrides includeEmptyState: false to prevent the empty state from showing

The only issue was merge nodes using a separate MergeComponent renderer that bypassed this override. This PR fixes that by rendering all builder nodes consistently through ComponentBase.

Closes #632

Open in Web Open in Cursor 

In the custom component builder page, there are no events or executions,
so the 'last event' / 'last run' sections on nodes should not be shown.

- Changed getBlockType to always return 'component' type in the builder,
  which ensures all nodes (including merge) use ComponentBase with the
  correct includeEmptyState: false override
- Removed hardcoded eventSections from storybook mock data to accurately
  represent the builder UI

Closes #632
@superplanehq-integration
Copy link
Copy Markdown

👋 Commands for maintainers:

  • /sp start - Start an ephemeral machine (takes ~30s)
  • /sp stop - Stop a running machine (auto-executed on pr close)

@shiroyasha shiroyasha closed this Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In custom component builder page, we shouldn’t show “last event” / "last run" section of nodes

2 participants