Skip to content

fix(nova): keep user message when stopping generation early #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MaheshtheDev wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −8
Open

fix(nova): keep user message when stopping generation early #1055

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions apps/web/components/chat/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,16 +549,11 @@ export function ChatSidebar({
}
}

// When the user stops generation before any assistant response arrives,
// remove the dangling user message so it isn't duplicated on the next send.
// Keep the user message on stop so it isn't lost when generation is halted
// before any assistant response arrives (ENG-732).
const handleStop = useCallback(() => {
stop()
setMessages((prev) => {
const last = prev[prev.length - 1]
if (last?.role === "user") return prev.slice(0, -1)
return prev
})
}, [stop, setMessages])
}, [stop])

const handleCopyMessage = useCallback((messageId: string, text: string) => {
analytics.chatMessageCopied({ message_id: messageId })
Expand Down
Loading