Skip to content

Conversation

@parshnt
Copy link
Member

@parshnt parshnt commented Jan 21, 2026

Change Summary

Added warning & confirmation when deploy will replace machines due to volume configuration changes.

Documentation

Copilot AI review requested due to automatic review settings January 21, 2026 09:36
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the deploy command to warn users when volume configuration changes will cause machines to be replaced, requiring explicit confirmation before proceeding. Previously, the system would immediately fail when detecting volume misconfigurations; now it provides a warning with actionable guidance and allows users to confirm their intent.

Changes:

  • Removed automatic warning from launchInputForUpdate when mounts section is removed from fly.toml
  • Added interactive prompt in validateVolumeConfig to warn users and request confirmation before detaching volumes
  • Enhanced validateVolumeConfig to accept context parameter for proper prompt handling

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
internal/command/deploy/machines_launchinput.go Removed inline warning when mount section is removed, as validation now happens earlier in the flow
internal/command/deploy/machines.go Added interactive prompt with confirmation when machine has volume but config doesn't specify one, includes proper error handling for non-interactive mode

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@parshnt parshnt merged commit e5c3ee0 into master Jan 21, 2026
42 of 43 checks passed
@parshnt parshnt deleted the detach-volume-mounts branch January 21, 2026 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants