Open
Conversation
Contributor
Author
|
Next steps : deliver similar deploy script & associated address registries for the following upgradeable SPR contracts :
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR intend to strengthen the deployment procedure of SPR contracts.
The deploy scripts now defines a new safety mechanism.
It compares each parameter in
AddressRegistryagainst the current live implementation.If a parameter differs and the corresponding env var is NOT set, the script reverts.
This ensures that parameter changes are always intentional and explicitly acknowledged.
The new deployment workflow is as follow :
Example :
To deploy an upgrade that only changes the Fonaine Beacon address: