fix: table background/width and marker color fixes #1795
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b1a5e022b2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const totalWidth = columnWidths.reduce((a, b) => a + b, 0); | ||
| // Scale to effectiveTargetWidth (resolved percentage or explicit width) | ||
| // This handles both scaling down (too wide) and scaling up (percentage-based) | ||
| if (totalWidth !== effectiveTargetWidth && effectiveTargetWidth > 0) { | ||
| if (totalWidth > effectiveTargetWidth && effectiveTargetWidth > 0) { | ||
| const scale = effectiveTargetWidth / totalWidth; |
There was a problem hiding this comment.
The new condition only scales column widths when totalWidth > effectiveTargetWidth, so tables with explicit/percentage widths where the OOXML grid sums to less than the resolved target will no longer be expanded to the target width. This means a 100% (or explicit) table can render narrower than its specified width, despite the preceding comment saying scaling should handle “scaling up (percentage-based).” This is a regression from the previous behavior where totalWidth !== effectiveTargetWidth, and it breaks tables that rely on percentage width to stretch columns to the available width.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Hi @harbournick! I did it intentionally in order to not to expand tables with layout=fixed and explicit width of columns.
No description provided.