refactor: reorganize style resolution in the layout engine (SD-1411) #1786
+7,472
−16,486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
January 19, 2026 13:39
luccas-harbour
force-pushed
the
luccas/sd-1411-reorganize-style-resolution-for-paragraphs-in-the-layout
branch
from
9ac7d31 to
68820c0
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1f93d3c2b3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
added 16 commits
January 20, 2026 10:41
harbournick
deleted the
luccas/sd-1411-reorganize-style-resolution-for-paragraphs-in-the-layout
branch
harbournick
pushed a commit
that referenced
this pull request
Jan 21, 2026
* feat: add v3 translator for w:aliases * feat: add v3 translator for w:name * feat: add v3 translator for w:basedOn * feat: add v3 translator for w:link * feat: add v3 translator for w:next * feat: register translators * refactor: use utility functions in w:hidden translator * feat: add v3 translator for w:autoRedefine * feat: add v3 translator for w:locked * feat: add v3 translator for w:personal * feat: add v3 translator for w:personalCompose * feat: add v3 translator for w:personalReply * feat: add v3 translator for w:qFormat * feat: add v3 translator for w:semiHidden * feat: add v3 translator for w:unhideWhenUsed * feat: register translators * feat: add v3 translator for w:rsid * feat: add v3 translator for w:uiPriority * feat: register translators * docs: fix typing * feat: add support for attribute handlers in nested props translators * feat: add v3 translator for w:tblStylePr * feat: add v3 translator for w:style * feat: add v3 translator for w:docDefaults * feat: add helper functions for encoding and decoding properties as map * feat: add v3 translator for w:lsdException * feat: add v3 translator for w:latentStyles * feat: add v3 translator for w:styles * feat: add v3 translator for w:start (child of w:lvl) * feat: add v3 translator for w:lvlRestart * feat: add v3 translator for w:lvlPicBulletId * feat: add v3 translator for w:isLgl * feat: add v3 translator for w:lvlJc * feat: add v3 translator for w:suff * feat: add v3 translator for w:lvlText * fix: circular import * feat: add v3 translator for w:numFmt * feat: add v3 translator for w:legacy * feat: add v3 translator for w:lvl * feat: add v3 translator for w:startOverride * feat: add v3 translator for w:lvlOverride * feat: add v3 translator for w:abstractNumId * feat: add v3 translator for w:num * feat: add v3 translator for w:nsid * feat: add v3 translator for w:tmpl * feat: add v3 translator for w:styleLink * feat: add v3 translator for w:numStyleLink * feat: add v3 translator for w:multiLevelType * feat: add v3 translator for w:abstractNum * feat: add v3 translator fow w:numIdMacAtCleanup * feat: add v3 translator fow w:numbering * feat: use v3 translator for linked styles and numbering * feat: add typing information for raw paragraph and run attrs * fix: rework list marker tab alignment * refactor: simplify list layout inputs and drop marker utils * feat: pass translated styles/numbering into editor state * refactor: migrate paragraph/run resolution to translated styles * fix: typing fixes * chore: format * test: adjust unit tests * fix: consider table style in style resolution * test: add tests for style resolution * fix: changes after rebase * fix: before and after auto spacing * fix: support w:numStyleLink in style resolution * fix: dropCap normalization * fix: pm-adapter build * fix: handle missing docDefaults * test: adjust existing tests * fix: font resolution * fix: resolution of tab stops * fix: style resolution for page references * test: adjust existing tests * feat: add support for "decimalZero" format for lists * fix: apply marks before inline run properties * fix: translation of table style properties * refactor: modify how table info is passed for style resolution * chore: remove unused code * fix: font family resolution * fix: adjust table band size translators to parse integer * feat: implement style resolution for table cells * fix: normalization of underline value * fix: font family resolution * fix: numbering props resolution * test: update e2e test screenshots --------- Co-authored-by: Luccas Correa <luccas@superdoc.dev>
harbournick
pushed a commit
that referenced
this pull request
Jan 21, 2026
# [1.8.0-next.10](v1.8.0-next.9...v1.8.0-next.10) (2026-01-21) ### Bug Fixes * reorganize style resolution in the layout engine (SD-1411) ([#1786](#1786)) ([1845b76](1845b76))
harbournick
pushed a commit
that referenced
this pull request
Jan 21, 2026
# [1.8.0](v1.7.0...v1.8.0) (2026-01-21) ### Bug Fixes * add addToHistory to new insertTrackedChange command ([#1767](#1767)) ([e5081be](e5081be)) * annotation drop ([#1789](#1789)) ([f384213](f384213)) * annotation selection ([#1762](#1762)) ([1c831cc](1c831cc)) * annotation selection, applying formatting ([#1784](#1784)) ([924af4b](924af4b)) * guard against null editor ref in telemetry handler ([#1763](#1763)) ([16b3a9a](16b3a9a)) * **layout:** default missing lineRule to auto for OOXML line spacing ([d0fd582](d0fd582)) * preserve nested comment ranges on export (SD-1518) ([#1765](#1765)) ([9b81f9a](9b81f9a)) * reorganize style resolution in the layout engine (SD-1411) ([#1786](#1786)) ([1845b76](1845b76)) * **search:** preserve leading/trailing whitespace in flexible matches ([#1788](#1788)) ([c5d6751](c5d6751)) * trigger release ([f826636](f826636)) ### Features * add insertTrackedChange programmatic shortcut ([#1761](#1761)) ([cd0628e](cd0628e)) * add visual indication for tracked change, comments and nested comments ([#1770](#1770)) ([8eb07e4](8eb07e4)) * comment anchor helpers ([#1796](#1796)) ([595bdc6](595bdc6)) * comment highlight config ([#1798](#1798)) ([aa7e957](aa7e957)) * **comments:** add position-ordered comments getter ([#1774](#1774)) ([bdac914](bdac914)) * include non-breaking spaces in search ([#1768](#1768)) ([d2784b9](d2784b9)) * search cross block anchor ([#1799](#1799)) ([09efa63](09efa63)) * view options print and web ([#1793](#1793)) ([82adcb1](82adcb1))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.