Skip to content

Add fallback handler for logging/setLevel#1

Open
krjoseph wants to merge 1 commit intosupercorp-ai:mainfrom
krjoseph:setloglevel-fallbackhandler
Open

Add fallback handler for logging/setLevel#1
krjoseph wants to merge 1 commit intosupercorp-ai:mainfrom
krjoseph:setloglevel-fallbackhandler

Conversation

@krjoseph
Copy link

@krjoseph krjoseph commented Oct 9, 2025

Otherwise the MCP Inspector attempts to set the log level and fails when the downstream MCP server does not support setting log-level
Screenshot 2025-10-09 at 11 34 18 AM

@krjoseph
Copy link
Author

krjoseph commented Oct 9, 2025

@Nedomas @vaaida Could you please review and merge?

@Nedomas Nedomas self-assigned this Oct 9, 2025
@Nedomas
Copy link
Member

Nedomas commented Oct 9, 2025

hey @krjoseph thanks for this!

I can’t seem to find any docs on fallbackRequesHandler. Could you link me to any? Will merge asap when I understand this.

@krjoseph
Copy link
Author

krjoseph commented Oct 9, 2025

Thanks for the quick response @Nedomas
Here is the existing reference of setting the fallbackRequesHandler for ping - https://github.com/supercorp-ai/superargs/blob/main/src/index.ts#L310 and the fallbackRequesHandler is invoked here https://github.com/supercorp-ai/superargs/blob/main/src/index.ts#L373-L374

@krjoseph
Copy link
Author

@Nedomas Gentle reminder 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants