Skip to content

Conversation

@dbkuppagiri
Copy link

No description provided.

@super30admin
Copy link
Owner

Strengths:

  • Your binary search implementation is well-written and follows good practices.
  • The comments are clear and helpful for understanding your approach.
  • You correctly implemented the binary search algorithm with proper boundary conditions.

Areas for Improvement:

  • You need to carefully read and understand the problem statement before starting to code. The problem you solved is completely different from the one you were supposed to solve.
  • For the actual problem (MyHashSet), you would need to implement a hash set data structure with add, remove, and contains operations, all with O(1) time complexity.
  • Pay attention to problem details and requirements to ensure you're solving the correct problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants