Skip to content

3 problems completed#2441

Open
BharathVuppala96 wants to merge 1 commit intosuper30admin:masterfrom
BharathVuppala96:master
Open

3 problems completed#2441
BharathVuppala96 wants to merge 1 commit intosuper30admin:masterfrom
BharathVuppala96:master

Conversation

@BharathVuppala96
Copy link
Copy Markdown

No description provided.

@super30admin
Copy link
Copy Markdown
Owner

Strengths:

  • Correct implementation of binary search for all three problems.
  • Appropriate time and space complexity for each solution.
  • Good variable naming and code structure.

Areas for Improvement:

  • Add comments to explain the logic, especially for the rotated sorted array search, which can be tricky to understand.
  • Consider using more descriptive variable names (e.g., low, high, mid instead of l, h, m) to improve readability further.
  • Ensure consistency in variable naming across all solutions (e.g., a and b in the 2D matrix solution could be low and high for consistency).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants