feat(hubspot): add api_key_name support for Vault secret lookup by name#543
Closed
JohnCari wants to merge 2 commits intosupabase:mainfrom
JohnCari:feat/hubspot-api-key-name
Closed
feat(hubspot): add api_key_name support for Vault secret lookup by name#543JohnCari wants to merge 2 commits intosupabase:mainfrom JohnCari:feat/hubspot-api-key-name
JohnCari wants to merge 2 commits intosupabase:mainfrom
JohnCari:feat/hubspot-api-key-name
Conversation
Add api_key_name option to HubSpot FDW, enabling Vault secret lookup by name for environment-agnostic configuration. Changes: - Add api_key_name option with precedence: api_key > api_key_id > api_key_name - Update authentication error message to include all three options - Update documentation with api_key_name examples Fixes #437
Contributor
Author
|
I have to improve a fews things, but will try to fix this! |
Add support for looking up Vault secrets by name in WASM-based FDWs. This enables environment-agnostic configuration where the same SQL works across dev, staging, and production environments. Changes: - Add get-vault-secret-by-name function to WIT interface (v1 and v2) - Implement host-side binding to call native get_vault_secret_by_name
Contributor
Author
|
Update: The implementation is now complete and ready for review. I've expanded the PR to include the full infrastructure needed for Added:
This follows the same pattern as the native Stripe FDW and enables any WASM FDW to use Vault secret lookup by name. The previous comment about needing improvements has been addressed - the PR now includes all necessary changes for the feature to work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
api_key_namesupport to HubSpot FDW, enabling Vault secret lookup by name for environment-agnostic configuration.This PR includes the complete infrastructure to support
api_key_namein WASM-based FDWs:Infrastructure Changes (enables feature for all WASM FDWs)
get-vault-secret-by-namefunction to WIT interface (v1 and v2)get_vault_secret_by_nameHubSpot FDW Changes
api_key_nameoption to HubSpot FDW authenticationChanges
wasm-wrappers/wit/v1/utils.witget-vault-secret-by-nameto WIT interfacewasm-wrappers/wit/v2/utils.witget-vault-secret-by-nameto WIT interfacewrappers/src/fdw/wasm_fdw/host/utils.rswasm-wrappers/fdw/hubspot_fdw/src/lib.rsapi_key_namesupportdocs/catalog/hubspot.mdTesting
api_keyandapi_key_idBenefits
Using
api_key_nameenables environment-agnostic configuration - the same SQL works across dev, staging, and production as long as each environment has a Vault secret with the same name.Fixes #437