chore: remove unused force-deregister variable from stage 2 AMI build

The force-deregister variable is not used in the stage2-nix-psql.pkr.hcl

Author: jfroche

.github/actions/build-ami/action.yml

@@ -87,6 +87,5 @@ runs:
           -var-file="common-nix.vars.pkr.hcl" \
           -var "ami_name=${{ inputs.ami_name_prefix }}" \
           -var 'ami_regions=${{ inputs.ami_regions }}' \
-          -var "force-deregister=true" \
           -var "git_sha=${{ inputs.git_sha }}" \
           stage2-nix-psql.pkr.hcl

.github/workflows/testinfra-ami-build.yml

@@ -97,7 +97,7 @@ jobs:
           region: ap-southeast-1
           ami_regions: '["ap-southeast-1"]'
           git_sha: ${{ github.sha }}
-          ami_name_prefix: "supabase-postgres-{{ github.run_id }}"
+          ami_name_prefix: "supabase-postgres-${{ github.run_id }}"
 
       - name: Run tests
         timeout-minutes: 10

nix/packages/build-test-ami.nix

@@ -120,7 +120,6 @@ runCommand "build-test-ami"
       -var "postgres-version=$RANDOM_STRING" \
       -var "region=$REGION" \
       -var 'ami_regions=["'"$REGION"'"]' \
-      -var "force-deregister=true" \
       -var "git_sha=$GIT_SHA" \
       stage2-nix-psql.pkr.hcl
 

stage2-nix-psql.pkr.hcl

@@ -37,10 +37,6 @@ variable "packer-execution-id" {
   default = "unknown"
 }
 
-variable "force-deregister" {
-  type    = bool
-  default = false
-}
 variable "git_sha" {
   type    = string
   default = env("GIT_SHA")

testinfra/README.md

@@ -58,7 +58,6 @@ AWS_PROFILE=supabase-dev packer build \
   -var "postgres-version=ci-ami-test" \
   -var "region=ap-southeast-1" \
   -var 'ami_regions=["ap-southeast-1"]' \
-  -var "force-deregister=true" \
   amazon-arm64.pkr.hcl
 
 # run tests