fix: declare different ami name prefix for test and release builds

In order to differentiate AMIs built for testing and those built for
release, we need different AMI name. This commit introduces a new input
parameter `ami_name_prefix`. For test builds, we set this prefix to
include the GitHub run ID, ensuring uniqueness across test builds. For
release builds, we use a static prefix "supabase-postgres".

Author: jfroche

.github/actions/build-ami/action.yml

@@ -14,6 +14,10 @@ inputs:
   git_sha:
     description: 'Git SHA for this build'
     required: true
+  ami_name_prefix:
+    description: 'Prefix for the AMI name'
+    required: false
+    default: 'supabase-postgres'
 
 outputs:
   stage2_ami_id:
@@ -63,7 +67,6 @@ runs:
           -var "region=${{ inputs.region }}" \
           -var 'ami_regions=${{ inputs.ami_regions }}' \
           -var-file="development-arm.vars.pkr.hcl" \
-          -var-file="common-nix.vars.pkr.hcl" \
           amazon-arm64-nix.pkr.hcl
 
     - name: Build AMI stage 2
@@ -82,7 +85,7 @@ runs:
           -var "postgres_major_version=${{ inputs.postgres_version }}" \
           -var-file="development-arm.vars.pkr.hcl" \
           -var-file="common-nix.vars.pkr.hcl" \
-          -var "postgres-version=${{ env.EXECUTION_ID }}" \
+          -var "ami_name=${{ inputs.ami_name_prefix }}" \
           -var 'ami_regions=${{ inputs.ami_regions }}' \
           -var "force-deregister=true" \
           -var "git_sha=${{ inputs.git_sha }}" \

.github/workflows/ami-release-nix.yml

@@ -131,7 +131,7 @@ jobs:
             -e "internal_artifacts_bucket=${{ secrets.PROD_ARTIFACTS_BUCKET }}" \
             -e "postgres_major_version=${{ matrix.postgres_version }}" \
             manifest-playbook.yml
-    
+
       - name: Upload nix flake revision to s3 prod
         run: |
           aws s3 cp /tmp/pg_binaries.tar.gz s3://${{ secrets.PROD_ARTIFACTS_BUCKET }}/upgrades/postgres/supabase-postgres-${{ steps.process_release_version.outputs.version }}/20.04.tar.gz

.github/workflows/testinfra-ami-build.yml

@@ -97,6 +97,7 @@ jobs:
           region: ap-southeast-1
           ami_regions: '["ap-southeast-1"]'
           git_sha: ${{ github.sha }}
+          ami_name_prefix: "supabase-postgres-{{ github.run_id }}"
 
       - name: Run tests
         timeout-minutes: 10