feat!: Structured output#316
Draft
gregnr wants to merge 9 commits into
Draft
Conversation
Coverage Report for CI Build 28470473556Warning No base build found for commit Coverage: 96.248%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
outputSchema/structuredContentfor MCP tools (AI-847) which implicitely fixesexecute_sqldoubling backslashes in results (#311).outputSchemais now returned as part oftools/listmcp-utilsvalidates every tool'sstructuredContentagainst itsoutputSchemaexecutefunction feed directly intostructuredContentformatResulthook that renders the returnedstructuredContentas text content (defaults toJSON.stringify)execute_sqlreturns rows asstructuredContentand the prompt-injection fence now lives only in text content viaformatResult. This removes the second JSON encode that was doubling backslashes in execute_sql corrupts backslash escaping in PL/pgSQL function bodies (round-trip failure) #311 (which confused LLMs)The main downside to doing this is we lose the prompt-injection fence if the MCP client decides to pass the structured content directly to the LLM instead of the text-formatted version. I think this is a fair trade-off though - it matches the spirit behind
structuredContent(actual structured content, not wrapped) and doesn't double JSON encode data. Client side prompt injection mitigations are a lot better than they used to be, so clients who want to usestructuredContentshould be willing to own this side of the security equation. Otherwise they can use the text version and continue to receive the wrapped version.Closes AI-847
Closes #311