Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
What is the current behavior?
OTPs are numeric. Typically 6 digits but configurable.
What is the new behavior?
OTPs can be alphanumeric, expanding the keyspace from 10 to 36 characters. Making a 6 character alphanumeric OTP roughly equivalent to a 10 character digit only OTP (31 bits vs 36 bits).
6 digit OTP: 10^6 --> 1,000,000
6 alphanumeric OTP: 36^6 --> 2,176,782,336
Additional context
Technically wouldn't be a breaking change but added a new config option to account for instances where client-side validation only expects digits. Or some other customer code-flows that expect OTPs to only be digits.