fix: prevent treesitter context panic on incomplete SQL#706
Closed
fix: prevent treesitter context panic on incomplete SQL#706
Conversation
Collaborator
|
Hmm, soooo the issue is actually that scope-boundaries are missing (block, transactions etc.).
that's not true — the issue is that a parent boundary was missing.
is that outdated? I'm only seeing an |
Collaborator
|
Added an alternative solution here: #709 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #704
Root cause:
ScopeTracker::register()inancestors.rsassumes the first node it encounters is always a scope boundary (statement,ERROR, orprogram). When tree-sitter parses malformed SQL, nodes likefunction_arguments,:=,keyword_begin, etc. can appear as the first traversed node, leavingself.scopesempty and hitting anunwrap_or_else(panic!).Fix:
self.scopesis empty. This gracefully degrades (completions/hover return nothing useful instead of crashing).