feat: LinkIdentity using idToken#128
Open
AndrewKahr wants to merge 4 commits into
Open
Conversation
AndrewKahr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR enables manual identity linking using native idTokens instead of only the PKCE flow. It also fixes an issue where the apiKey was lost during a redirect in the PKCE linking flow, causing an error. It now follows the logic in the JS library to avoid a redirect. There was also a minor typo in the unlinking flow's URL builder. Finally, the GitHub Actions tags were bumped due to the versions going EOL.
What is the current behavior?
Currently, there is no function to link with an idToken while the JS library supports this behavior.
What is the new behavior?
You can now manually link identities using idToken in addition to PKCE.