Draft
Conversation
Member
|
Hi @rh2082. Thanks for this PR! |
DanRyanIrish
approved these changes
Dec 1, 2025
| @@ -1,44 +1,28 @@ | |||
| # This file is used to configure the behavior of pytest when using the Astropy | |||
Member
There was a problem hiding this comment.
Can you add all these comments back in as they are part of the template and we might want to uncomment certain bits of code that they suggest at a later date.
sunkit_spex/conftest.py
Outdated
Comment on lines
26
to
28
| timeenergy = wcs_et() | ||
| data = np.arange(1, 11) * u.watt | ||
| spec = Spectrum(data, wcs=timeenergy) |
Member
There was a problem hiding this comment.
This needs to be part of a fixture too.
Co-authored-by: DanRyanIrish <ryand5@tcd.ie>
DanRyanIrish
reviewed
Dec 1, 2025
Co-authored-by: DanRyanIrish <ryand5@tcd.ie>
Member
|
This looks like a good start. Now try including fixtures for the other combinations of axes listed in the issue. |
DanRyanIrish
reviewed
Dec 4, 2025
Co-authored-by: DanRyanIrish <ryand5@tcd.ie>
Member
|
Home human-readable fixture names and some short docstrings would be helpful. |
Member
|
@samaloney Do you want all of these fixtures to have uncertainties, masks, or other supporting data? |
Contributor
Author
|
@samaloney Would you mind reviewing this please and letting me know what attributes other than coordinates you'd like me to add? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a time-energy spectrum object to conftest.py