Defer thermal model setup until actually needed#184
Draft
samaloney wants to merge 2 commits intosunpy:mainfrom
Draft
Defer thermal model setup until actually needed#184samaloney wants to merge 2 commits intosunpy:mainfrom
samaloney wants to merge 2 commits intosunpy:mainfrom
Conversation
Member
Author
|
Early thoughts @DanRyanIrish ? |
Contributor
|
@samaloney I have also been working on the thermal model on the branch https://github.com/jajmitchell/sunkit-spex/tree/thermal-model-astropy-wrapper, still a bit messy, and definitely needs streamlining, but the wrapper seems to work with unit handling and produces the same results as the thermal_emission model. I was planning on opening a PR on this, but there would be lots of conflict with this one, how should we go forward with it? |
Member
Author
|
@jajmitchell I'd prob just open the PR anyway, conflicts can't really be helped sometimes |
Member
Author
|
I think this could actually be better accomplished with custom module attributes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the way the thermal module configuration is loaded it uses a class to defer the process until the props are actually needed and also caches them.
At the moment I haven't implemented a setter as I don't know how to verify the data would be in the correct format and not really sure it's needed.