Add patient-level leakage checks for dataset splits#1159
Open
tippered1-debug wants to merge 1 commit into
Open
Add patient-level leakage checks for dataset splits#1159tippered1-debug wants to merge 1 commit into
tippered1-debug wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds helper utilities to audit patient-level leakage across dataset splits.
Healthcare datasets often contain multiple samples per patient. If the same patient appears in both train and validation/test splits, evaluation metrics may be inflated because the model is partially evaluated on patients already seen during training.
The new helpers inspect the actual samples in each split and verify that patient IDs are disjoint.
Changes
get_patient_ids(...)to extract patient IDs from datasets, subsets, sample collections, or ID collections.check_patient_disjoint(...)to return a report with split counts and patient overlaps.assert_patient_disjoint(...)to raise a clear error when patient overlap is detected.pyhealth.datasets.patient_iderrors.Tests
python -m unittest tests.core.test_patient_disjoint -v