POC: iceberg-testing conformance fixtures (submodule)#2
Open
sungwy wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This POC adds language-neutral Apache Iceberg conformance fixtures to the Rust repo via a git submodule, and documents which spec “surfaces” these fixtures cover (with the Rust harness intentionally deferred).
Changes:
- Added
iceberg-testing/as a git submodule pointing tosungwy/iceberg-testing. - Added
conformance/README.mddocumenting fixture scope (types parse/serialize, bucket-hash KATs, delete-file decoding) and how to consume the fixtures locally.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
conformance/README.md |
Documents the conformance fixture surfaces and local consumption steps; notes the harness is deferred. |
.gitmodules |
Registers the iceberg-testing submodule URL and path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sungwy
force-pushed
the
conformance-iceberg-testing
branch
6 times, most recently
from
c52e951 to
ff031f7
Compare
Pin sungwy/iceberg-testing as a git submodule and add an integration test (crates/iceberg/tests/conformance.rs) that walks its language-neutral fixtures against this crate: - type strings: deserialize the type and re-serialize to the canonical schema-JSON form (parse + round-trip) - bucket hash: the Appendix B 32-bit Known-Answer-Test, via transform_literal Cases this crate does not satisfy yet are listed as expected failures with a tracking issue: geometry/geography are not implemented (apache#1884) and fixed[...] rejects internal whitespace. Decimal whitespace and the byte-boundary decimal bucket hashes pass, where some other implementations diverge. The Tests CI job checks out the submodule so the suite runs; the tests skip cleanly when it is absent. Adds serde_json as a dev-dependency.
sungwy
force-pushed
the
conformance-iceberg-testing
branch
from
ff031f7 to
841245c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POC pinning the language-neutral conformance fixtures from sungwy/iceberg-testing as a git submodule (
iceberg-testing/).Test Surfaces: type-string parse + re-serialize, the Appendix B bucket-hash Known-Answer-Test (incl. byte-boundary decimals), and delete-file decode by field-id