Ilariaorlando symfony 80

[ilaria-orlando]

upgrade to symfony 8.0 and php 8.5

Summary by Sourcery

Upgrade the project to PHP 8.5 and Symfony 8, updating related dependencies and CI/deployment configuration.

Enhancements:

• Raise PHP platform requirement to 8.5 and bump Symfony and related bundle/package versions to their Symfony 8–compatible releases.
• Adjust password validation attribute configuration to use the new named-argument syntax for PasswordStrength constraints.
• Remove deprecated Doctrine DBAL configuration option use_savepoints from doctrine.yaml.

Build:

• Update composer development dependencies (e.g. fixtures bundle and deployer) to newer major versions compatible with the upgraded stack.

CI:

• Switch GitLab CI jobs to PHP 8.5 Docker images for builds, quality checks, dependency scans, and tests.

Deployment:

• Update deployment configuration to use PHP 8.5 images and URLs for staging and production environments.

[sourcery-ai]

Reviewer's Guide

Upgrades the project to PHP 8.5 and Symfony 8.0 (including related bundles/tools) and adjusts CI, deployment, and a couple of validation attributes to be compatible with the new versions.

Updated class diagram for user password DTOs with Symfony 8 validation

classDiagram
    class UserDataTransferObject

    class RegisterUser {
        +string password
        +constraints NotBlank
        +constraints PasswordStrength minScore_STRENGTH_STRONG
        +constraints NotCompromisedPassword
        +constraints Length min_12
    }

    class ResetPassword {
        +string password
        +constraints PasswordStrength minScore_STRENGTH_STRONG
        +constraints NotCompromisedPassword
        +constraints Length min_12
    }

    RegisterUser --|> UserDataTransferObject

    class PasswordStrengthConstraint {
        +int STRENGTH_STRONG
        +int minScore
    }

    RegisterUser --> PasswordStrengthConstraint
    ResetPassword --> PasswordStrengthConstraint

Loading

File-Level Changes

Change	Details	Files
Raise PHP and Symfony-related dependency versions for the application and dev tooling.	Bump minimum PHP version requirement from 8.4 to 8.5. Upgrade Symfony core and related packages from ^7.3 to ^8.0 where used. Update sumocoders/framework-core-bundle and deployer-sumo versions to their newer major releases compatible with PHP 8.5/Symfony 8. Upgrade doctrine/doctrine-fixtures-bundle to ^4.3 and other dev dependencies to versions compatible with Symfony 8.	composer.json composer.lock
Update CI pipeline and deployment configuration to use PHP 8.5 images and URLs.	Switch GitLab CI Docker images from PHP 8.4 variants to PHP 8.5 variants for build, QA, dependency scanning, and deploy jobs. Adjust staging environment URL domain to reference php85 instead of php84. Update deployment configuration to set php_version to 8.5 and sync other environment expectations.	.gitlab-ci.yml deploy.php
Adjust password validation attributes for Symfony 8 attribute syntax expectations.	Replace array-based configuration of PasswordStrength constraint with named arguments syntax for minScore in RegisterUser DTO. Apply the same PasswordStrength constraint syntax change in ResetPassword to ensure compatibility with Symfony Validator 8. Keep existing NotBlank, NotCompromisedPassword, and Length constraints unchanged.	src/Message/User/RegisterUser.php src/Message/User/ResetPassword.php
Tweak Doctrine DBAL configuration for Symfony/Doctrine 8 compatibility.	Remove use_savepoints configuration flag from Doctrine DBAL settings, relying on defaults appropriate for the upgraded stack.	config/packages/doctrine.yaml
Align local PHP version configuration with the new runtime version.	Update the project’s PHP version file to declare PHP 8.5 as the local/runtime version, matching composer and CI configuration.	.php-version

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• Removing doctrine.dbal.use_savepoints changes transaction behavior (especially around nested transactions/rollbacks); double-check this is intentional and that any code or tests relying on savepoints still behave as expected under the new default.
• In composer.json, symfony/maker-bundle is still constrained as *; now that you're on Symfony 8 it may be safer to pin it to a compatible major/minor range to avoid unexpected BC breaks on future installs.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Removing `doctrine.dbal.use_savepoints` changes transaction behavior (especially around nested transactions/rollbacks); double-check this is intentional and that any code or tests relying on savepoints still behave as expected under the new default.
- In `composer.json`, `symfony/maker-bundle` is still constrained as `*`; now that you're on Symfony 8 it may be safer to pin it to a compatible major/minor range to avoid unexpected BC breaks on future installs.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[tijsverkoyen]

Pas dit eens aan naar dev03.sumocoders.eu aub

[tijsverkoyen]

• Removing doctrine.dbal.use_savepoints changes transaction behavior (especially around nested transactions/rollbacks); double-check this is intentional and that any code or tests relying on savepoints still behave as expected under the new default.

Mag je negeren.

• In composer.json, symfony/maker-bundle is still constrained as *; now that you're on Symfony 8 it may be safer to pin it to a compatible major/minor range to avoid unexpected BC breaks on future installs.

Is misschien wel geen slecht idee? Eventueel op ^1.65 instellen?