Draft
Conversation
We were partially overriding the frontend with the cunningham theme meaning at build time. We stop to do this way to do it only from the configuration theme. This way it will be easier to maintain and to update. We improve as well the typing with more global types like Image type from logo and icons, and HTMLLinkElement type for the favicon, meaning you can really override compoments from the configuration theme.
On the DSFR instance the title will not be displayed anymore in favor of a icon that include the title. So we make the title optional, it will be configurable from the theme configuration.
|
Size Change: -1.55 kB (-0.04%) Total Size: 4.2 MB
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix few minor issues with the implementation of the new colors and themes from the UI Kit 2.
#1722
Proposal