Skip to content

♻️(frontend) replace hardcoded colors with contextual tokens #1858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AntoLC merged 1 commit into from
Mar 9, 2026
Merged

♻️(frontend) replace hardcoded colors with contextual tokens #1858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/frontend/apps/impress/src/components/DropButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import { useFocusStore } from '@/stores';
import { BoxProps } from './Box';

const StyledPopover = styled(Popover)`
background-color: white;
background-color: var(--c--contextuals--background--surface--primary);
border-radius: var(--c--globals--spacings--st);
box-shadow: 0 0 6px 0 rgba(0, 0, 145, 0.1);
border: 1px solid var(--c--contextuals--border--surface--primary);
Expand Down
2 changes: 1 addition & 1 deletion src/frontend/apps/impress/src/components/dropdown-menu/DropdownMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ export const DropdownMenu = ({
key={option.label}
$align="center"
$justify="space-between"
$background={colorsTokens['gray-000']}
$background="var(--c--contextuals--background--surface--primary)"
$color={colorsTokens['brand-600']}
$padding={{ vertical: 'xs', horizontal: 'base' }}
$width="100%"
Expand Down
2 changes: 1 addition & 1 deletion src/frontend/apps/impress/src/features/docs/doc-editor/components/DocEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export const DocEditorContainer = ({
<Box $css="flex:1;" $position="relative" $width="100%">
<Box
$padding={{ top: 'md', bottom: '2rem' }}
$background="white"
$background="var(--c--contextuals--background--surface--primary)"
className={clsx('--docs--editor-container', {
'--docs--doc-readonly': readOnly,
'--docs--doc-deleted': isDeletedDoc,
Expand Down
6 changes: 5 additions & 1 deletion src/frontend/apps/impress/src/features/docs/doc-table-content/components/Heading.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,11 @@ export const Heading = ({
});
}}
$radius="var(--c--globals--spacings--st)"
$background={isActive ? `${colorsTokens['gray-100']}` : 'none'}
$background={
isActive
? 'var(--c--contextuals--background--semantic--neutral--secondary)'
: 'none'
}
$css={css`
text-align: left;
&:focus-visible {
Expand Down
2 changes: 1 addition & 1 deletion src/frontend/apps/impress/src/features/docs/doc-table-content/components/TableContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ export const TableContent = () => {
border: 1px solid ${colorsTokens['brand-100']};
overflow: hidden;
border-radius: ${spacingsTokens['3xs']};
background: ${colorsTokens['gray-000']};
background: var(--c--contextuals--background--surface--primary);
${isOpen &&
css`
display: flex;
Expand Down
2 changes: 1 addition & 1 deletion src/frontend/apps/impress/src/features/docs/doc-tree/components/DocSubPageItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ export const DocSubPageItem = (props: TreeViewNodeProps<Doc>) => {
aria-disabled={isDisabled}
onKeyDown={handleKeyDown}
$css={css`
background-color: var(--c--globals--colors--gray-000);
background-color: var(--c--contextuals--background--surface--primary);
.light-doc-item-actions {
display: ${menuOpen || !isDesktop ? 'flex' : 'none'};
right: var(--c--globals--spacings--0);
Expand Down
8 changes: 6 additions & 2 deletions src/frontend/apps/impress/src/features/left-panel/components/LeftPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,9 @@ export const LeftPanel = () => {
height: calc(100vh - ${HEADER_HEIGHT}px);
width: 100%;
overflow: hidden;
background-color: var(--c--globals--colors--gray-000);
background-color: var(
--c--contextuals--background--surface--primary
);
`}
className="--docs--left-panel-desktop"
as="nav"
Expand Down Expand Up @@ -73,7 +75,9 @@ export const LeftPanel = () => {
border-right: 1px solid var(--c--globals--colors--gray-200);
position: fixed;
transform: translateX(${isPanelOpenState ? '0' : '-100dvw'});
background-color: var(--c--globals--colors--gray-000);
background-color: var(
--c--contextuals--background--surface--primary
);
overflow-y: auto;
overflow-x: hidden;
`}
Expand Down
Loading