Skip to content

🐛(backend) properly encode attachment upload content-disposition header #1812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
networkException wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🐛(backend) properly encode attachment upload content-disposition header #1812

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/backend/core/api/viewsets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
from django.utils import timezone
from django.utils.decorators import method_decorator
from django.utils.functional import cached_property
from django.utils.http import content_disposition_header
from django.utils.text import capfirst, slugify
from django.utils.translation import gettext_lazy as _

Expand Down Expand Up @@ -1426,11 +1427,11 @@ def attachment_upload(self, request, *args, **kwargs):
or serializer.validated_data["is_unsafe"]
):
extra_args.update(
{"ContentDisposition": f'attachment; filename="{file_name:s}"'}
{"ContentDisposition": content_disposition_header(as_attachment=True, filename=file_name)}
)
else:
extra_args.update(
{"ContentDisposition": f'inline; filename="{file_name:s}"'}
{"ContentDisposition": content_disposition_header(as_attachment=False, filename=file_name)}
)

file = serializer.validated_data["file"]
Expand Down